From: Daniel Starke Date: Thu, 17 Aug 2023 09:32:25 +0000 (+0200) Subject: tty: n_gsm: remove unneeded initialization of ret in gsm_dlci_config X-Git-Tag: v6.6.17~4037^2~43 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e1c90bbb5f5178967d5d3c0917de847e88ebe398;p=platform%2Fkernel%2Flinux-rpi.git tty: n_gsm: remove unneeded initialization of ret in gsm_dlci_config The variable 'ret' is not used before assignment from gsm_activate_mux(). Still it gets initialized to zero at declaration. Fix this as remarked in the link below by moving the declaration to the first assignment. Link: https://lore.kernel.org/all/b42bc4d1-cc9d-d115-c981-aaa053bdc59f@kernel.org/ Signed-off-by: Daniel Starke Link: https://lore.kernel.org/r/20230817093231.2317-3-daniel.starke@siemens.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 27da795ca348..a4df0a20f212 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -3280,7 +3280,6 @@ static void gsm_copy_config_values(struct gsm_mux *gsm, static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c) { - int ret = 0; int need_close = 0; int need_restart = 0; @@ -3359,7 +3358,7 @@ static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c) * and removing from the mux array */ if (gsm->dead) { - ret = gsm_activate_mux(gsm); + int ret = gsm_activate_mux(gsm); if (ret) return ret; if (gsm->initiator)