From: Mauro Carvalho Chehab Date: Tue, 3 Feb 2015 18:36:28 +0000 (-0200) Subject: [media] rtl28xxu: properly initialize pdata X-Git-Tag: v5.15~14799^2~1424 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e181b1f19045a5843aefafa561207fbea8bd2973;p=platform%2Fkernel%2Flinux-starfive.git [media] rtl28xxu: properly initialize pdata As complained by smatch: drivers/media/usb/dvb-usb-v2/rtl28xxu.c:1159 rtl2832u_tuner_attach() info: 'pdata' is not actually initialized (unreached code). Cc: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index d88f799..77dcfdf 100644 --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c @@ -1055,10 +1055,13 @@ static int rtl2832u_tuner_attach(struct dvb_usb_adapter *adap) struct i2c_board_info info; struct i2c_client *client; struct v4l2_subdev *subdev = NULL; + struct platform_device *pdev; + struct rtl2832_sdr_platform_data pdata; dev_dbg(&d->intf->dev, "\n"); memset(&info, 0, sizeof(struct i2c_board_info)); + memset(&pdata, 0, sizeof(pdata)); switch (dev->tuner) { case TUNER_RTL2832_FC0012: @@ -1155,9 +1158,6 @@ static int rtl2832u_tuner_attach(struct dvb_usb_adapter *adap) /* register SDR */ switch (dev->tuner) { - struct platform_device *pdev; - struct rtl2832_sdr_platform_data pdata = {}; - case TUNER_RTL2832_FC0012: case TUNER_RTL2832_FC0013: case TUNER_RTL2832_E4000: