From: Timothy Pearson Date: Mon, 16 Jul 2018 19:20:42 +0000 (-0500) Subject: radeonsi: Use signed char for color_interp_vgpr_index X-Git-Tag: upstream/19.0.0~3734 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e1621fda84d92f154b19c5bf9562ee6963414399;p=platform%2Fupstream%2Fmesa.git radeonsi: Use signed char for color_interp_vgpr_index color_interp_vgpr_index was declared as a generic char value. Because signed values are used in this variable, the result was not safe across architectures and crashed on ppc64[el] and arm. Declare color_interp_vgpr_index as a signed type. Signed-off-by: Timothy Pearson Signed-off-by: Marek Olšák --- diff --git a/src/gallium/drivers/radeonsi/si_shader.h b/src/gallium/drivers/radeonsi/si_shader.h index ffe13b7..a2fb48a 100644 --- a/src/gallium/drivers/radeonsi/si_shader.h +++ b/src/gallium/drivers/radeonsi/si_shader.h @@ -502,7 +502,7 @@ union si_shader_part_key { unsigned ancillary_vgpr_index:5; unsigned wqm:1; char color_attr_index[2]; - char color_interp_vgpr_index[2]; /* -1 == constant */ + signed char color_interp_vgpr_index[2]; /* -1 == constant */ } ps_prolog; struct { struct si_ps_epilog_bits states;