From: Eric Paris Date: Tue, 5 Nov 2013 15:48:02 +0000 (-0500) Subject: audit: use memset instead of trying to initialize field by field X-Git-Tag: v3.13-rc1~19^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e13f91e3c57986a609c10ddf94af0546a2a97dce;p=kernel%2Fkernel-generic.git audit: use memset instead of trying to initialize field by field We currently are setting fields to 0 to initialize the structure declared on the stack. This is a bad idea as if the structure has holes or unpacked space these will not be initialized. Just use memset. This is not a performance critical section of code. Signed-off-by: Eric Paris --- diff --git a/kernel/audit.c b/kernel/audit.c index e0f7767..3ce60e0 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -759,7 +759,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) switch (msg_type) { case AUDIT_GET: - status_set.mask = 0; + memset(&status_set, 0, sizeof(status_set)); status_set.enabled = audit_enabled; status_set.failure = audit_failure; status_set.pid = audit_pid;