From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Fri, 21 Jul 2023 14:55:49 +0000 (+0300)
Subject: drm/amd/display: Unlock on error path in dm_handle_mst_sideband_msg_ready_event()
X-Git-Tag: v6.1.52~779
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e139cc2974b801f3f6e38efa047a7e3b7121fc8d;p=platform%2Fkernel%2Flinux-starfive.git

drm/amd/display: Unlock on error path in dm_handle_mst_sideband_msg_ready_event()

[ Upstream commit 38ac4e8385ffb275b1837986ca6c16f26ea028c5 ]

This error path needs to unlock the "aconnector->handle_mst_msg_ready"
mutex before returning.

Fixes: 4f6d9e38c4d2 ("drm/amd/display: Add polling method to handle MST reply packet")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 0570868..d07e105 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -677,7 +677,7 @@ void dm_handle_mst_sideband_msg_ready_event(
 
 			if (retry == 3) {
 				DRM_ERROR("Failed to ack MST event.\n");
-				return;
+				break;
 			}
 
 			drm_dp_mst_hpd_irq_send_new_request(&aconnector->mst_mgr);