From: Paolo Bonzini Date: Fri, 7 Sep 2012 15:30:41 +0000 (+0200) Subject: target: do not submit a zero-bio I/O request X-Git-Tag: v3.7-rc1~61^2~27 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e0de44573637ba43e43ae1af042e109bbf2b6dd0;p=profile%2Fivi%2Fkernel-x86-ivi.git target: do not submit a zero-bio I/O request scsi_setup_fs_cmnd does not like to receive requests with no bios attached to it. Special-case zero-length reads and writes, by not submitting any bio. Testcase: sg_raw /dev/sdb 28 00 00 00 00 00 00 00 00 00 should not fail panics with the rest of the series but not this patch behaves correctly without or with this series Signed-off-by: Paolo Bonzini Signed-off-by: Nicholas Bellinger --- diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index 5b745bb..29408d4 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c @@ -654,6 +654,12 @@ static int iblock_execute_rw(struct se_cmd *cmd) goto fail; cmd->priv = ibr; + if (!sgl_nents) { + atomic_set(&ibr->pending, 1); + iblock_complete_cmd(cmd); + return 0; + } + bio = iblock_get_bio(cmd, block_lba, sgl_nents); if (!bio) goto fail_free_ibr;