From: Ben Hutchings Date: Fri, 19 Feb 2010 13:29:27 +0000 (+0000) Subject: sfc: Fix sign of efx_mcdi_poll_reboot() error in efx_mcdi_poll() X-Git-Tag: v4.14-rc1~20222^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e0bf54c93a15c365a37cfc4fe0137f5bc012d1b9;p=platform%2Fkernel%2Flinux-rpi.git sfc: Fix sign of efx_mcdi_poll_reboot() error in efx_mcdi_poll() efx_mcdi_poll() uses positive error numbers, matching the MCDI protocol. It must negate the result of efx_mcdi_poll_reboot() which returns the usual negative error numbers. Signed-off-by: Ben Hutchings Signed-off-by: David S. Miller --- diff --git a/drivers/net/sfc/mcdi.c b/drivers/net/sfc/mcdi.c index 9f035b9f0350..f66b3da6ddff 100644 --- a/drivers/net/sfc/mcdi.c +++ b/drivers/net/sfc/mcdi.c @@ -127,7 +127,7 @@ static int efx_mcdi_poll(struct efx_nic *efx) efx_dword_t reg; /* Check for a reboot atomically with respect to efx_mcdi_copyout() */ - rc = efx_mcdi_poll_reboot(efx); + rc = -efx_mcdi_poll_reboot(efx); if (rc) goto out;