From: Sebastian Dröge <sebastian@centricular.com>
Date: Mon, 19 May 2014 07:01:46 +0000 (+0200)
Subject: omxvideodec: Check return values of buffer pool config parsing functions
X-Git-Tag: 1.2.0~40
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e08c0dc88a91108a6d9fec024ad0a4ee47dabb50;p=platform%2Fupstream%2Fgst-omx.git

omxvideodec: Check return values of buffer pool config parsing functions

CID 1214588
---

diff --git a/omx/gstomxvideodec.c b/omx/gstomxvideodec.c
index 335d17c8569..27f3b3ba238 100644
--- a/omx/gstomxvideodec.c
+++ b/omx/gstomxvideodec.c
@@ -561,8 +561,16 @@ gst_omx_video_dec_allocate_output_buffers (GstOMXVideoDec * self)
     GstAllocator *allocator;
 
     config = gst_buffer_pool_get_config (pool);
-    gst_buffer_pool_config_get_params (config, &caps, NULL, &min, &max);
-    gst_buffer_pool_config_get_allocator (config, &allocator, NULL);
+    if (!gst_buffer_pool_config_get_params (config, &caps, NULL, &min, &max)) {
+      GST_ERROR_OBJECT (self, "Can't get buffer pool params");
+      err = OMX_ErrorUndefined;
+      goto done;
+    }
+    if (!gst_buffer_pool_config_get_allocator (config, &allocator, NULL)) {
+      GST_ERROR_OBJECT (self, "Can't get buffer pool allocator");
+      err = OMX_ErrorUndefined;
+      goto done;
+    }
 
     /* Need at least 2 buffers for anything meaningful */
     min = MAX (MAX (min, port->port_def.nBufferCountMin), 4);