From: Edward Hervey <bilboed@bilboed.com>
Date: Sat, 6 Jan 2007 14:08:26 +0000 (+0000)
Subject: gst/real/gstrealaudiodec.c: Don't call the RAFreeDecoder since it randomly causes... 
X-Git-Tag: 1.19.3~507^2~21238
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e049792b5d8afd354e091d9a881f8bf25cb5413c;p=platform%2Fupstream%2Fgstreamer.git

gst/real/gstrealaudiodec.c: Don't call the RAFreeDecoder since it randomly causes segfaults.

Original commit message from CVS:
* gst/real/gstrealaudiodec.c: (gst_real_audio_dec_finalize):
Don't call the RAFreeDecoder since it randomly causes segfaults.
* gst/real/gstrealaudiodec.h:
indent properly.
---

diff --git a/ChangeLog b/ChangeLog
index 49fe691..beb10c5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2007-01-06  Edward Hervey  <edward@fluendo.com>
 
+	* gst/real/gstrealaudiodec.c: (gst_real_audio_dec_finalize):
+	Don't call the RAFreeDecoder since it randomly causes segfaults.
+	* gst/real/gstrealaudiodec.h:
+	indent properly.
+
+2007-01-06  Edward Hervey  <edward@fluendo.com>
+
 	Patch by: Lutz Mueller <lutz@topfrose.de>
 	
 	* gst/real/gstrealvideodec.c: (gst_real_video_dec_decode),
diff --git a/gst/real/gstrealaudiodec.c b/gst/real/gstrealaudiodec.c
index a7f37ba..d073c7b 100644
--- a/gst/real/gstrealaudiodec.c
+++ b/gst/real/gstrealaudiodec.c
@@ -362,7 +362,11 @@ gst_real_audio_dec_finalize (GObject * object)
 
   if (dec->context) {
     dec->funcs.RACloseCodec (dec->context);
-    dec->funcs.RAFreeDecoder (dec->context);
+    /* Calling RAFreeDecoder seems to randomly cause SEGFAULTs.
+     * All other implementation (xine, mplayer) have also got this function call
+     * commented. So until we know more, we comment it too. */
+
+    /*     dec->funcs.RAFreeDecoder (dec->context); */
     dec->context = NULL;
   }
   if (dec->handle) {
diff --git a/gst/real/gstrealaudiodec.h b/gst/real/gstrealaudiodec.h
index 517b077..b1f6864 100644
--- a/gst/real/gstrealaudiodec.h
+++ b/gst/real/gstrealaudiodec.h
@@ -25,7 +25,6 @@
 #include <gst/audio/audio.h>
 
 G_BEGIN_DECLS
-
 #define GST_TYPE_REAL_AUDIO_DEC (gst_real_audio_dec_get_type())
 #define GST_REAL_AUDIO_DEC(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj),GST_TYPE_REAL_AUDIO_DEC,GstRealAudioDec))
 #define GST_REAL_AUDIO_DEC_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST((klass),GST_TYPE_REAL_AUDIO_DEC,GstRealAudioDecClass))
@@ -33,8 +32,9 @@ G_BEGIN_DECLS
 typedef struct _GstRealAudioDec GstRealAudioDec;
 typedef struct _GstRealAudioDecClass GstRealAudioDecClass;
 
-GType gst_real_audio_dec_get_type (void) G_GNUC_CONST;
+GType
+gst_real_audio_dec_get_type (void)
+    G_GNUC_CONST;
 
 G_END_DECLS
-
 #endif /* __GST_REAL_AUDIO_DEC_H__ */