From: Eric Dumazet <edumazet@google.com>
Date: Sat, 16 Mar 2019 20:09:53 +0000 (-0700)
Subject: tun: add a missing rcu_read_unlock() in error path
X-Git-Tag: v4.19.33~103
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e044d21c2999d35c26cc15011e6478e2a9eaee63;p=platform%2Fkernel%2Flinux-rpi3.git

tun: add a missing rcu_read_unlock() in error path

commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream.

In my latest patch I missed one rcu_read_unlock(), in case
device is down.

Fixes: 4477138fa0ae ("tun: properly test for IFF_UP")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 76dd858..044d5c3 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1915,6 +1915,7 @@ drop:
 	rcu_read_lock();
 	if (unlikely(!(tun->dev->flags & IFF_UP))) {
 		err = -EIO;
+		rcu_read_unlock();
 		goto drop;
 	}