From: Stanley Chu <stanley.chu@mediatek.com>
Date: Mon, 15 Apr 2019 12:23:38 +0000 (+0800)
Subject: scsi: ufs: Print real incorrect request response code
X-Git-Tag: v5.4-rc1~699^2~91
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=e0347d894ae879a3cb8977ebca43eb04a5fae1c1;p=platform%2Fkernel%2Flinux-rpi.git

scsi: ufs: Print real incorrect request response code

If UFS device responds an unknown request response code, we can not know
what it was via logs because the code is replaced by "DID_ERROR << 16"
before log printing.

Fix this to provide precise request response code information for easier
issue breakdown.

Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b9a3d67..8c1c551 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4704,10 +4704,10 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
 				"Reject UPIU not fully implemented\n");
 			break;
 		default:
-			result = DID_ERROR << 16;
 			dev_err(hba->dev,
 				"Unexpected request response code = %x\n",
 				result);
+			result = DID_ERROR << 16;
 			break;
 		}
 		break;