From: Dhirendra Kumar Date: Wed, 3 Apr 2013 09:21:08 +0000 (+0900) Subject: Fix for remember password feature X-Git-Tag: 2.1_release~215 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dfa5e7e0a2ede4884d149eb6a354df6afcea3eb6;p=platform%2Fframework%2Fweb%2Fwebkit-efl.git Fix for remember password feature [Title] Fixed remember username and password in case when username is input tag with type equal to email [Issue#] WEB-567 [Problem] Remember password feature was working only for password field and not for username field in case of sites like www.gmail.com [Cause] The logic to populate data was missing if the type of input tag was email and hence was ignoring it [Solution] Added condition to check if input tag has type as email while populating value [Developer] Dhirendra Kumar(dhirendra.kr@samsung.com) Change-Id: I8c6a883492761e4eea934e25d6c99c7b55f3df30 --- diff --git a/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp b/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp index fcdcee1..b86f6dc 100755 --- a/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp +++ b/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp @@ -1636,7 +1636,7 @@ void ewk_view_form_password_data_fill(Evas_Object* ewkView) for (size_t i = 0; i < passwordFormData.size(); i++) { passwordFormAutofill += String::format(" inputFields = document.getElementsByName(\"%s\");" " for (var i = 0; i < inputFields.length; i++)" - " if (inputFields[i].tagName.toLowerCase() == \"input\" && (inputFields[i].type.toLowerCase() == \"text\" || inputFields[i].type.toLowerCase() == \"password\"))" + " if (inputFields[i].tagName.toLowerCase() == \"input\" && (inputFields[i].type.toLowerCase() == \"text\" || inputFields[i].type.toLowerCase() == \"password\" || inputFields[i].type.toLowerCase() == \"email\"))" " inputFields[i].value = \"%s\";", passwordFormData[i].first.utf8().data(), passwordFormData[i].second.utf8().data()); }