From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 30 Nov 2017 14:23:54 +0000 (+0000)
Subject: chcr: ensure cntrl is initialized to fix bit-wise or'ing of garabage data
X-Git-Tag: v4.19~1578^2~131
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=df807a19957c2917fd5a4f5812e240a250066742;p=platform%2Fkernel%2Flinux-rpi3.git

chcr: ensure cntrl is initialized to fix bit-wise or'ing of garabage data

In the case where skb->ip_summed != CHECKSUM_PARTIAL then cntrl contains
garbage value and this is possibly being bit-wise or'd and stored into
cpl->ctrl1.  Fix this by initializing cntrl to zero.

Cleans up clang warning:
drivers/crypto/chelsio/chcr_ipsec.c:374:9: warning: The left expression
of the compound assignment is an uninitialized value. The computed value
will also be garbage

Fixes: 6dad4e8ab3ec ("chcr: Add support for Inline IPSec")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/chelsio/chcr_ipsec.c b/drivers/crypto/chelsio/chcr_ipsec.c
index a0f003f..64a030f 100644
--- a/drivers/crypto/chelsio/chcr_ipsec.c
+++ b/drivers/crypto/chelsio/chcr_ipsec.c
@@ -350,7 +350,7 @@ inline void *copy_cpltx_pktxt(struct sk_buff *skb,
 	struct port_info *pi;
 	struct sge_eth_txq *q;
 	struct cpl_tx_pkt_core *cpl;
-	u64 cntrl;
+	u64 cntrl = 0;
 	u32 ctrl0, qidx;
 
 	pi = netdev_priv(dev);