From: Bhaktipriya Shridhar Date: Wed, 9 Mar 2016 18:33:49 +0000 (+0530) Subject: staging: comedi: drivers: amplc_pci230: Prefer using macro DIV_ROUND_UP X-Git-Tag: v4.6-rc1~103^2~234 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=df6ba4f16170838482319f40ce1a2b280b9e80f3;p=platform%2Fkernel%2Flinux-exynos.git staging: comedi: drivers: amplc_pci230: Prefer using macro DIV_ROUND_UP The macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /(d)). It clarifies the divisor calculations. This was done using the coccinelle script: @@ expression e1; expression e2; @@ ( - ((e1) + e2 - 1) / (e2) + DIV_ROUND_UP(e1,e2) | - ((e1) + (e2 - 1)) / (e2) + DIV_ROUND_UP(e1,e2) ) Signed-off-by: Bhaktipriya Shridhar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c b/drivers/staging/comedi/drivers/amplc_pci230.c index d1fe88a..907c39c 100644 --- a/drivers/staging/comedi/drivers/amplc_pci230.c +++ b/drivers/staging/comedi/drivers/amplc_pci230.c @@ -642,7 +642,7 @@ static unsigned int pci230_divide_ns(uint64_t ns, unsigned int timebase, case CMDF_ROUND_DOWN: break; case CMDF_ROUND_UP: - div += (rem + timebase - 1) / timebase; + div += DIV_ROUND_UP(rem, timebase); break; } return div > UINT_MAX ? UINT_MAX : (unsigned int)div;