From: Laurent Pinchart Date: Fri, 19 Jun 2015 11:51:22 +0000 (-0300) Subject: [media] v4l: vsp1: Fix plane stride and size checks X-Git-Tag: v4.14-rc1~4413^2~357 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=df5c3e7c8a87a4384ff7a0adba16baae9a40a566;p=platform%2Fkernel%2Flinux-rpi.git [media] v4l: vsp1: Fix plane stride and size checks The checks need to be performed on up to two planes, as the third plane, if present, must have the same stride and size as the second plane. The code incorrectly performs the checks on at least two planes instead of at most two planes, fix it. Signed-off-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c index 770e08d..3c124c1 100644 --- a/drivers/media/platform/vsp1/vsp1_video.c +++ b/drivers/media/platform/vsp1/vsp1_video.c @@ -245,7 +245,7 @@ static int __vsp1_video_try_format(struct vsp1_video *video, * the datasheet, strides not aligned to a multiple of 128 bytes result * in image corruption. */ - for (i = 0; i < max(info->planes, 2U); ++i) { + for (i = 0; i < min(info->planes, 2U); ++i) { unsigned int hsub = i > 0 ? info->hsub : 1; unsigned int vsub = i > 0 ? info->vsub : 1; unsigned int align = 128;