From: Dan Carpenter Date: Thu, 7 Nov 2013 07:48:49 +0000 (+0300) Subject: net: make ndev->irq signed for error handling X-Git-Tag: accepted/tizen/common/20141203.182822~1141^2~31 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=df42153c59a38a65c6f7440d5c70d87d1c24438d;p=platform%2Fkernel%2Flinux-arm64.git net: make ndev->irq signed for error handling There is a bug in cpsw_probe() where we do: ndev->irq = platform_get_irq(pdev, 0); if (ndev->irq < 0) { The problem is that "ndev->irq" is unsigned so the error handling doesn't work. I have changed it to a regular int. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index e6353ca..b6f6efb 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1132,7 +1132,7 @@ struct net_device { unsigned long mem_end; /* shared mem end */ unsigned long mem_start; /* shared mem start */ unsigned long base_addr; /* device I/O address */ - unsigned int irq; /* device IRQ number */ + int irq; /* device IRQ number */ /* * Some hardware also needs these fields, but they are not