From: Derek Foreman Date: Tue, 15 Jan 2019 01:01:05 +0000 (-0600) Subject: focus_manager: fix memory leaks X-Git-Tag: submit/tizen/20190116.045417~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=df33ae1b0d2e7d6e394e21e22d282548c1270669;p=platform%2Fupstream%2Fefl.git focus_manager: fix memory leaks _set_a_without_b() makes a list clone internally, so cloning the list first will leak a copy. Signed-off-by: Derek Foreman Reviewed-by: Marcel Hollerbach Differential Revision: https://phab.enlightenment.org/D7622 --- diff --git a/src/lib/elementary/efl_ui_focus_manager_sub.c b/src/lib/elementary/efl_ui_focus_manager_sub.c index 7fb1383..eb05f97 100644 --- a/src/lib/elementary/efl_ui_focus_manager_sub.c +++ b/src/lib/elementary/efl_ui_focus_manager_sub.c @@ -63,8 +63,7 @@ _border_flush(Eo *obj, Efl_Ui_Focus_Manager_Sub_Data *pd) eina_iterator_free(borders); //elements which are not in the current border elements - tmp = eina_list_clone(pd->current_border); - tmp = _set_a_without_b(tmp , selection); + tmp = _set_a_without_b(pd->current_border, selection); EINA_LIST_FREE(tmp, node) { @@ -73,8 +72,7 @@ _border_flush(Eo *obj, Efl_Ui_Focus_Manager_Sub_Data *pd) } //set of the elements which are new without those which are currently registered - tmp = eina_list_clone(selection); - tmp = _set_a_without_b(tmp, pd->current_border); + tmp = _set_a_without_b(selection, pd->current_border); EINA_LIST_FREE(tmp, node) {