From: Johan Hovold <johan@hovoldconsulting.com>
Date: Tue, 17 Mar 2015 09:55:51 +0000 (+0100)
Subject: greybus: vibrator: fix memory leak in error path
X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1686
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=deeb57f5bd990f747815216ab772e92413848f6e;p=platform%2Fkernel%2Flinux-rpi.git

greybus: vibrator: fix memory leak in error path

Fix memory leak in connection_init error path.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
---

diff --git a/drivers/staging/greybus/vibrator.c b/drivers/staging/greybus/vibrator.c
index b6ec9f2..c92c69e 100644
--- a/drivers/staging/greybus/vibrator.c
+++ b/drivers/staging/greybus/vibrator.c
@@ -127,7 +127,7 @@ static int gb_vibrator_connection_init(struct gb_connection *connection)
 			    "vibrator%d", vib->minor);
 	if (IS_ERR(dev)) {
 		retval = -EINVAL;
-		goto error;
+		goto err_idr_remove;
 	}
 	vib->dev = dev;
 
@@ -140,12 +140,14 @@ static int gb_vibrator_connection_init(struct gb_connection *connection)
 	retval = sysfs_create_group(&dev->kobj, vibrator_groups[0]);
 	if (retval) {
 		device_unregister(dev);
-		goto error;
+		goto err_idr_remove;
 	}
 #endif
 
 	return 0;
 
+err_idr_remove:
+	idr_remove(&minors, vib->minor);
 error:
 	kfree(vib);
 	return retval;