From: Father Chrysostomos Date: Sat, 28 Jul 2012 06:59:19 +0000 (-0700) Subject: doop.c: Simplify do_trans’ un-cow logic X-Git-Tag: upstream/5.20.0~6002 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=deaf58b8802900d0a53e4faca7896971ce9a9dad;p=platform%2Fupstream%2Fperl.git doop.c: Simplify do_trans’ un-cow logic Since it calls SvPV_force_nomg a little further on, there is no need for a separate sv_force_normal call to handle COWs. --- diff --git a/doop.c b/doop.c index bfcdef5..9d75b3d 100644 --- a/doop.c +++ b/doop.c @@ -632,9 +632,7 @@ Perl_do_trans(pTHX_ SV *sv) PERL_ARGS_ASSERT_DO_TRANS; if (SvREADONLY(sv) && !(PL_op->op_private & OPpTRANS_IDENTICAL)) { - if (SvIsCOW(sv)) - sv_force_normal_flags(sv, 0); - if (SvREADONLY(sv)) + if (!SvIsCOW(sv)) Perl_croak_no_modify(aTHX); } (void)SvPV_const(sv, len);