From: Daeseok Youn Date: Wed, 5 Nov 2014 08:58:11 +0000 (+0900) Subject: staging: dgap: remove unnecessary function X-Git-Tag: v3.19-rc1~66^2~417 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=deaa2c2021c2c00401933f84023bfc4c0a60e281;p=platform%2Fkernel%2Flinux-exynos.git staging: dgap: remove unnecessary function The dgap_init_global() initialize the dgap_board that is a global variable as static and dgap_poll_timer. But init_timer() is called twice in dgap_start() and dgap_board doesn't need to be initialized to NULL. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 293dc33..aa393d2 100644 --- a/drivers/staging/dgap/dgap.c +++ b/drivers/staging/dgap/dgap.c @@ -7019,23 +7019,6 @@ static struct pci_driver dgap_driver = { }; /* - * dgap_init_globals() - * - * This is where we initialize the globals from the static insmod - * configuration variables. These are declared near the head of - * this file. - */ -static void dgap_init_globals(void) -{ - unsigned int i; - - for (i = 0; i < MAXBOARDS; i++) - dgap_board[i] = NULL; - - init_timer(&dgap_poll_timer); -} - -/* * Start of driver. */ static int dgap_start(void) @@ -7044,12 +7027,6 @@ static int dgap_start(void) unsigned long flags; struct device *device; - /* - * make sure that the globals are - * init'd before we do anything else - */ - dgap_init_globals(); - dgap_numboards = 0; pr_info("For the tools package please visit http://www.digi.com\n");