From: Florian Fainelli Date: Fri, 15 Jul 2016 23:40:22 +0000 (-0700) Subject: et131x: Fix logical vs bitwise check in et131x_tx_timeout() X-Git-Tag: v4.14-rc1~2874^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=de702da7a823ab0c4a1e53ed79a2695f0d453855;p=platform%2Fkernel%2Flinux-rpi.git et131x: Fix logical vs bitwise check in et131x_tx_timeout() We should be using a logical check here instead of a bitwise operation to check if the device is closed already in et131x_tx_timeout(). Reported-by: coverity (CID 146498) Fixes: 38df6492eb511 ("et131x: Add PCIe gigabit ethernet driver et131x to drivers/net") Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c index 30defe6..821d86c 100644 --- a/drivers/net/ethernet/agere/et131x.c +++ b/drivers/net/ethernet/agere/et131x.c @@ -3851,7 +3851,7 @@ static void et131x_tx_timeout(struct net_device *netdev) unsigned long flags; /* If the device is closed, ignore the timeout */ - if (~(adapter->flags & FMP_ADAPTER_INTERRUPT_IN_USE)) + if (!(adapter->flags & FMP_ADAPTER_INTERRUPT_IN_USE)) return; /* Any nonrecoverable hardware error?