From: Markus Elfring Date: Wed, 11 Feb 2015 18:10:21 +0000 (-0800) Subject: Input: adi - remove an unnecessary check X-Git-Tag: v4.14-rc1~4^2~490 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=de3748f66f21642543e6f1acb1002937a8d2de2e;p=platform%2Fkernel%2Flinux-rpi.git Input: adi - remove an unnecessary check The input_free_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/joystick/adi.c b/drivers/input/joystick/adi.c index b784257..d09cefa 100644 --- a/drivers/input/joystick/adi.c +++ b/drivers/input/joystick/adi.c @@ -535,8 +535,7 @@ static int adi_connect(struct gameport *gameport, struct gameport_driver *drv) } } fail2: for (i = 0; i < 2; i++) - if (port->adi[i].dev) - input_free_device(port->adi[i].dev); + input_free_device(port->adi[i].dev); gameport_close(gameport); fail1: gameport_set_drvdata(gameport, NULL); kfree(port);