From: Andy Grover <agrover@redhat.com>
Date: Tue, 26 Nov 2013 19:49:24 +0000 (-0800)
Subject: target: Remove extra percpu_ref_init
X-Git-Tag: accepted/tizen/common/20141203.182822~881^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=de06875f089678f4f9f1e8d5e1421fb0ceab12d0;p=platform%2Fkernel%2Flinux-arm64.git

target: Remove extra percpu_ref_init

lun->lun_ref is also initialized in core_tpg_post_addlun, so it doesn't
need to be done in core_tpg_setup_virtual_lun0.

(nab: Drop left-over percpu_ref_cancel_init in failure path)

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---

diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c
index f755712..2a573de 100644
--- a/drivers/target/target_core_tpg.c
+++ b/drivers/target/target_core_tpg.c
@@ -656,15 +656,9 @@ static int core_tpg_setup_virtual_lun0(struct se_portal_group *se_tpg)
 	spin_lock_init(&lun->lun_sep_lock);
 	init_completion(&lun->lun_ref_comp);
 
-	ret = percpu_ref_init(&lun->lun_ref, core_tpg_lun_ref_release);
-	if (ret < 0)
-		return ret;
-
 	ret = core_tpg_post_addlun(se_tpg, lun, lun_access, dev);
-	if (ret < 0) {
-		percpu_ref_cancel_init(&lun->lun_ref);
+	if (ret < 0)
 		return ret;
-	}
 
 	return 0;
 }