From: Thomas Meyer Date: Fri, 2 Dec 2011 12:35:43 +0000 (+0000) Subject: ll_temac: Use kcalloc instead of kzalloc to allocate array X-Git-Tag: v3.3-rc1~182^2~362 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=ddf98e6d30a966dbd6e675c90e2caa5b9486e519;p=profile%2Fivi%2Fkernel-x86-ivi.git ll_temac: Use kcalloc instead of kzalloc to allocate array The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index 282330d..903a77b 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -237,7 +237,7 @@ static int temac_dma_bd_init(struct net_device *ndev) struct sk_buff *skb; int i; - lp->rx_skb = kzalloc(sizeof(*lp->rx_skb) * RX_BD_NUM, GFP_KERNEL); + lp->rx_skb = kcalloc(RX_BD_NUM, sizeof(*lp->rx_skb), GFP_KERNEL); if (!lp->rx_skb) { dev_err(&ndev->dev, "can't allocate memory for DMA RX buffer\n");