From: Frederic Weisbecker Date: Mon, 31 May 2010 22:43:07 +0000 (+0200) Subject: perf: Do the comm inheritance per thread in event__process_task X-Git-Tag: v2.6.35-rc4~2^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dd833d713ccc79e00176eb1b3a6c65638c44e27b;p=platform%2Fkernel%2Flinux-exynos.git perf: Do the comm inheritance per thread in event__process_task event__process_task() doesn't propagate the comm copy on clone, but only on process fork. So we loose all the tid:comm resolution for tasks that aren't a main process thread. Progragate the per thread granularity to event__process_task for pid resolution. This fixes various unresolved pids in perf sched, especially when we trace multithread processes. The problem is quickly reproducible with the messaging benchmark using the multithread mode "-t" : perf sched record perf bench sched messaging -t Signed-off-by: Frederic Weisbecker Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Arnaldo Carvalho de Melo Cc: Paul Mackerras Cc: Tom Zanussi Cc: Stephane Eranian --- diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c index d28d809..1f08f00 100644 --- a/tools/perf/util/event.c +++ b/tools/perf/util/event.c @@ -532,16 +532,11 @@ out_problem: int event__process_task(event_t *self, struct perf_session *session) { - struct thread *thread = perf_session__findnew(session, self->fork.pid); - struct thread *parent = perf_session__findnew(session, self->fork.ppid); + struct thread *thread = perf_session__findnew(session, self->fork.tid); + struct thread *parent = perf_session__findnew(session, self->fork.ptid); dump_printf("(%d:%d):(%d:%d)\n", self->fork.pid, self->fork.tid, self->fork.ppid, self->fork.ptid); - /* - * A thread clone will have the same PID for both parent and child. - */ - if (thread == parent) - return 0; if (self->header.type == PERF_RECORD_EXIT) return 0;