From: Wang Ming <machel@vivo.com>
Date: Thu, 27 Jul 2023 19:37:50 +0000 (-0500)
Subject: firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe
X-Git-Tag: v6.6.7~2016^2~76
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dd218433f2b635d97e8fda3eed047151fd528ce4;p=platform%2Fkernel%2Flinux-starfive.git

firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe

The devm_memremap() function returns error pointers.
It never returns NULL. Fix the check.

Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Cc: stable@vger.kernel.org
Signed-off-by: Wang Ming <machel@vivo.com>
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
Link: https://lore.kernel.org/r/20230727193750.983795-1-dinguyen@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 2d67412..cab11af 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -756,7 +756,7 @@ svc_create_memory_pool(struct platform_device *pdev,
 	paddr = begin;
 	size = end - begin;
 	va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
-	if (!va) {
+	if (IS_ERR(va)) {
 		dev_err(dev, "fail to remap shared memory\n");
 		return ERR_PTR(-EINVAL);
 	}