From: Dave Gordon Date: Mon, 13 Jun 2016 16:57:30 +0000 (+0100) Subject: drm/i915/guc: remove writes to GEN8_DRBREG registers X-Git-Tag: v4.14-rc1~2243^2~42^2~470 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dd16107f91a80bfee96f96737cf94003b8817ee2;p=platform%2Fkernel%2Flinux-rpi.git drm/i915/guc: remove writes to GEN8_DRBREG registers These registers are not actually writable by the CPU; only the GuC can actually program them. So let's not do writes that have no effect. Signed-off-by: Dave Gordon Reviewed-by: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c index 21daaa5..1589fe9 100644 --- a/drivers/gpu/drm/i915/i915_guc_submission.c +++ b/drivers/gpu/drm/i915/i915_guc_submission.c @@ -252,14 +252,9 @@ static void guc_disable_doorbell(struct intel_guc *guc, doorbell->db_status = GUC_DOORBELL_DISABLED; - I915_WRITE(drbreg, I915_READ(drbreg) & ~GEN8_DRB_VALID); - value = I915_READ(drbreg); WARN_ON((value & GEN8_DRB_VALID) != 0); - I915_WRITE(GEN8_DRBREGU(client->doorbell_id), 0); - I915_WRITE(drbreg, 0); - /* XXX: wait for any interrupts */ /* XXX: wait for workqueue to drain */ }