From: Tobias Jakobi Date: Tue, 22 Aug 2017 14:19:36 +0000 (+0200) Subject: drm/exynos: mixer: fix chroma comment in vp_video_buffer() X-Git-Tag: v4.14-rc1~8^2~2^2~6 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dc500cfb869d776e78e4a62b20b65f8208e2c695;p=platform%2Fkernel%2Flinux-rpi.git drm/exynos: mixer: fix chroma comment in vp_video_buffer() The current comment sounds like the division op is done to compensate for some hardware erratum. But the chroma plane having half the height of the luma plane is just the way NV12/NV21 is defined, so clarify this behaviour. Signed-off-by: Tobias Jakobi Signed-off-by: Inki Dae --- diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index a998a8d..cbd949a 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -532,7 +532,7 @@ static void vp_video_buffer(struct mixer_context *ctx, /* setting size of input image */ vp_reg_write(res, VP_IMG_SIZE_Y, VP_IMG_HSIZE(fb->pitches[0]) | VP_IMG_VSIZE(fb->height)); - /* chroma height has to reduced by 2 to avoid chroma distorions */ + /* chroma plane for NV12/NV21 is half the height of the luma plane */ vp_reg_write(res, VP_IMG_SIZE_C, VP_IMG_HSIZE(fb->pitches[0]) | VP_IMG_VSIZE(fb->height / 2));