From: lrn@chromium.org <lrn@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Date: Wed, 8 Sep 2010 10:33:15 +0000 (+0000)
Subject: Don't generate preparse data if lazy-flag is false.
X-Git-Tag: upstream/4.7.83~21231
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dc4898aae285aae95dd75f55d7a2dd1508293c51;p=platform%2Fupstream%2Fv8.git

Don't generate preparse data if lazy-flag is false.

Review URL: http://codereview.chromium.org/3304012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5427 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
---

diff --git a/src/compiler.cc b/src/compiler.cc
index bf6d41d..a7580e4 100755
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -269,9 +269,20 @@ Handle<SharedFunctionInfo> Compiler::Compile(Handle<String> source,
   }
 
   if (result.is_null()) {
-    // No cache entry found. Do pre-parsing and compile the script.
+    // No cache entry found. Do pre-parsing, if it makes sense, and compile
+    // the script.
+    // Building preparse data that is only used immediately after is only a
+    // saving if we might skip building the AST for lazily compiled functions.
+    // I.e., preparse data isn't relevant when the lazy flag is off, and
+    // for small sources, odds are that there aren't many functions
+    // that would be compiled lazily anyway, so we skip the preparse step
+    // in that case too.
+    // TODO(lrn): Maybe *only* collect function info, not symbol info, in
+    // this case, since it's just replacing one hash-lookup with another.
     ScriptDataImpl* pre_data = input_pre_data;
-    if (pre_data == NULL && source_length >= FLAG_min_preparse_length) {
+    if (pre_data == NULL
+        && FLAG_lazy
+        && source_length >= FLAG_min_preparse_length) {
       pre_data = PreParse(source, NULL, extension);
     }