From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Fri, 3 May 2013 18:56:02 +0000 (+0200)
Subject: build: tiny reduction in code duplication
X-Git-Tag: v1.13.1d~2^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dc3cdb1d53c51c95981dbf77b05f70e4040075b9;p=platform%2Fupstream%2Fautomake.git

build: tiny reduction in code duplication

The code was only duplicated two times, but we are soon going to
need a third occurrence, and that would be one to much.

* Makefile.am (extend_path): New.
(update_mans): Use it instead of copying & pasting its contents.
($(srcdir)/doc/amhello-1.0.tar.gz): Likewise, and minor related
adjustments.

Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
---

diff --git a/Makefile.am b/Makefile.am
index ab1dfed..7ac03df 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -73,6 +73,11 @@ EXTRA_DIST += \
   syntax-checks.mk \
   HACKING
 
+# For some tests or targets, we need to have the just-build automake and
+# aclocal scripts avaiable on PATH.
+extend_PATH = \
+  { PATH='$(abs_builddir)/t/wrap'$(PATH_SEPARATOR)$$PATH && export PATH; }
+
 # Make versioned links.  We only run the transform on the root name;
 # then we make a versioned link with the transformed base name.  This
 # seemed like the most reasonable approach.
@@ -574,8 +579,7 @@ EXTRA_DIST += doc/help2man
 update_mans = \
   $(AM_V_GEN): \
     && $(MKDIR_P) doc \
-    && PATH="$(abs_builddir)/t/wrap$(PATH_SEPARATOR)$$PATH" \
-    && export PATH \
+    && $(extend_PATH) \
     && $(PERL) $(srcdir)/doc/help2man --output=$@
 
 doc/aclocal.1 doc/automake.1:
@@ -617,13 +621,11 @@ dist_doc_DATA = $(srcdir)/doc/amhello-1.0.tar.gz
 
 # We depend on configure.ac so that we regenerate the tarball
 # whenever the Automake version changes.
-# aclocal-$(APIVERSION) and automake-$(APIVERSION) are generated by
-# configure in 't/wrap'.
 $(srcdir)/doc/amhello-1.0.tar.gz: $(amhello_sources) $(srcdir)/configure.ac
 	$(AM_V_GEN)tmp=amhello-output.tmp \
-	  && PATH="$(abs_top_builddir)/t/wrap$(PATH_SEPARATOR)$$PATH" \
-	  && export PATH \
 	  && $(am__cd) $(srcdir)/doc/amhello \
+	  && : Make our	aclocal and automake avaiable before system ones; \
+	  && $(extend_PATH) \
 	  && ACLOCAL=aclocal-$(APIVERSION) && export ACLOCAL \
 	  && AUTOMAKE=automake-$(APIVERSION) && export AUTOMAKE \
 	  && AUTOCONF='$(am_AUTOCONF)' && export AUTOCONF \