From: Sangchul Lee <sc11.lee@samsung.com>
Date: Mon, 26 Sep 2022 03:24:35 +0000 (+0900)
Subject: webrtc_display: Return NULL in case of mm_display_interface_init() failure
X-Git-Tag: accepted/tizen/unified/20220927.132346^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dc2835654ea923707c62a818dbf8015538af01b2;p=platform%2Fcore%2Fapi%2Fwebrtc.git

webrtc_display: Return NULL in case of mm_display_interface_init() failure

[Version] 0.3.249
[Issue Type] Bug fix

Change-Id: I389a9a8e99e5ebfd2544a641a1b30f61c8bd155f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
---

diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec
index 648edcfe..84bf91cf 100644
--- a/packaging/capi-media-webrtc.spec
+++ b/packaging/capi-media-webrtc.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    0.3.248
+Version:    0.3.249
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/webrtc_display.c b/src/webrtc_display.c
index 60514e24..2c2c7f80 100644
--- a/src/webrtc_display.c
+++ b/src/webrtc_display.c
@@ -767,17 +767,18 @@ webrtc_display_s *_alloc_display(void)
 {
 	webrtc_display_s *display = g_new0(webrtc_display_s, 1);
 
-	g_mutex_init(&display->mutex);
-
-	if (mm_display_interface_init(&display->mm_display) != MM_ERROR_NONE)
-		LOG_WARNING("failed to mm_display_interface_init()");
-	else
-		LOG_DEBUG("init mm_display[%p]", display->mm_display);
+	if (mm_display_interface_init(&display->mm_display) != MM_ERROR_NONE) {
+		LOG_ERROR("failed to mm_display_interface_init()");
+		g_free(display);
+		return NULL;
+	}
 
+	g_mutex_init(&display->mutex);
 	display->mode = WEBRTC_DISPLAY_MODE_LETTER_BOX;
 	display->visible = true;
 
-	LOG_DEBUG("alloc display[%p, mode:%u, visible:%u]", display, display->mode, display->visible);
+	LOG_DEBUG("alloc display[%p, mm_display:%p, mode:%u, visible:%u]",
+		display, display->mm_display, display->mode, display->visible);
 
 	return display;
 }