From: Minkyu Kang Date: Thu, 24 Dec 2009 00:41:37 +0000 (+0900) Subject: s5pc110: gpio: codes clean X-Git-Tag: JA02_20100111~57 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dc139e8bd902bf4fc02b2e0bedfab69229b5db9d;p=kernel%2Fu-boot.git s5pc110: gpio: codes clean Signed-off-by: Minkyu Kang --- diff --git a/cpu/arm_cortexa8/s5pc1xx/gpio.c b/cpu/arm_cortexa8/s5pc1xx/gpio.c index 1f2ad79..861a314 100644 --- a/cpu/arm_cortexa8/s5pc1xx/gpio.c +++ b/cpu/arm_cortexa8/s5pc1xx/gpio.c @@ -32,7 +32,7 @@ #define PULL_MODE(x, v) ((v) << ((x) << 1)) #define DRV_MASK(x) (0x3 << (x)) -#define DRV_SET(x,m) ((m) << (x)) +#define DRV_SET(x, m) ((m) << (x)) #define RATE_MASK(x) (0x1 << (x + 16)) #define RATE_SET(x) (0x1 << (x + 16)) @@ -89,6 +89,7 @@ void gpio_set_pull(struct s5pc1xx_gpio_bank *bank, int gpio, int mode) value = readl(&bank->pull); value &= ~PULL_MASK(gpio); + switch (mode) { case GPIO_PULL_DOWN: case GPIO_PULL_UP: @@ -97,6 +98,7 @@ void gpio_set_pull(struct s5pc1xx_gpio_bank *bank, int gpio, int mode) default: break; } + writel(value, &bank->pull); }