From: Joerg Roedel Date: Thu, 13 Aug 2015 09:15:13 +0000 (+0200) Subject: iommu/vt-d: Use BUG_ON instead of if () BUG() X-Git-Tag: v4.14-rc1~4724^2^6~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dc02e46e8d0234eed9f6e42f50763b406c380bc4;p=platform%2Fkernel%2Flinux-rpi.git iommu/vt-d: Use BUG_ON instead of if () BUG() Found by a coccicheck script. Signed-off-by: Joerg Roedel --- diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index 8834765..2a7e017 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -4760,8 +4760,7 @@ static size_t intel_iommu_unmap(struct iommu_domain *domain, /* Cope with horrid API which requires us to unmap more than the size argument if it happens to be a large-page mapping. */ - if (!pfn_to_dma_pte(dmar_domain, iova >> VTD_PAGE_SHIFT, &level)) - BUG(); + BUG_ON(!pfn_to_dma_pte(dmar_domain, iova >> VTD_PAGE_SHIFT, &level)); if (size < VTD_PAGE_SIZE << level_to_offset_bits(level)) size = VTD_PAGE_SIZE << level_to_offset_bits(level);