From: Dan Carpenter Date: Thu, 13 Jan 2011 20:00:00 +0000 (+0000) Subject: dm log: use PTR_ERR value instead of ENOMEM X-Git-Tag: v2.6.38-rc1~221^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dbc883f1570d992ba926a8c9e22140ba473c6cc1;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git dm log: use PTR_ERR value instead of ENOMEM It's nicer to return the PTR_ERR() value instead of just returning -ENOMEM. In the current code the PTR_ERR() value is always equal to -ENOMEM so this doesn't actually affect anything, but still... In addition, dm_dirty_log_create() doesn't check for a specific -ENOMEM return. So this change is safe relative to potential for a non -ENOMEM return in the future. Signed-off-by: Dan Carpenter Acked-by: Jonathan Brassow Signed-off-by: Mike Snitzer Signed-off-by: Alasdair G Kergon --- diff --git a/drivers/md/dm-log.c b/drivers/md/dm-log.c index 33420e6..6951536 100644 --- a/drivers/md/dm-log.c +++ b/drivers/md/dm-log.c @@ -455,7 +455,7 @@ static int create_log_context(struct dm_dirty_log *log, struct dm_target *ti, r = PTR_ERR(lc->io_req.client); DMWARN("couldn't allocate disk io client"); kfree(lc); - return -ENOMEM; + return r; } lc->disk_header = vmalloc(buf_size);