From: Maxim Levitsky <maximlevitsky@gmail.com>
Date: Wed, 28 Jul 2010 15:53:16 +0000 (+0300)
Subject: mtd: blkdevs: fix crash related to sysfs attributes.
X-Git-Tag: v2.6.36-rc1~301^2~26
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dba76c033f1b88b6eb0fa697b824f954b11f8a97;p=profile%2Fivi%2Fkernel-x86-ivi.git

mtd: blkdevs: fix crash related to sysfs attributes.

Remove the attributes group before disk to avoid use after free

Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---

diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c
index a6bb586..89e07e5 100644
--- a/drivers/mtd/mtd_blkdevs.c
+++ b/drivers/mtd/mtd_blkdevs.c
@@ -410,13 +410,14 @@ int del_mtd_blktrans_dev(struct mtd_blktrans_dev *old)
 		BUG();
 	}
 
-	/* Stop new requests to arrive */
-	del_gendisk(old->disk);
-
 	if (old->disk_attributes)
 		sysfs_remove_group(&disk_to_dev(old->disk)->kobj,
 						old->disk_attributes);
 
+	/* Stop new requests to arrive */
+	del_gendisk(old->disk);
+
+
 	/* Stop the thread */
 	kthread_stop(old->thread);