From: rossberg@chromium.org Date: Mon, 15 Jul 2013 14:12:20 +0000 (+0000) Subject: Fix sloppy-mode 'const' under Harmony flag. X-Git-Tag: upstream/4.7.83~13373 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=db76aa2717bd65d810275014ed4090fa28bd1f79;p=platform%2Fupstream%2Fv8.git Fix sloppy-mode 'const' under Harmony flag. R=yangguo@chromium.org BUG=173361 Review URL: https://codereview.chromium.org/19199002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15670 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/parser.cc b/src/parser.cc index ca2d022..b062673 100644 --- a/src/parser.cc +++ b/src/parser.cc @@ -1563,24 +1563,18 @@ void Parser::Declare(Declaration* declaration, bool resolve, bool* ok) { // For global const variables we bind the proxy to a variable. ASSERT(resolve); // should be set by all callers Variable::Kind kind = Variable::NORMAL; - var = new(zone()) Variable(declaration_scope, - name, - mode, - true, - kind, - kNeedsInitialization); + var = new(zone()) Variable( + declaration_scope, name, mode, true, kind, + kNeedsInitialization, proxy->interface()); } else if (declaration_scope->is_eval_scope() && declaration_scope->is_classic_mode()) { // For variable declarations in a non-strict eval scope the proxy is bound // to a lookup variable to force a dynamic declaration using the // DeclareContextSlot runtime function. Variable::Kind kind = Variable::NORMAL; - var = new(zone()) Variable(declaration_scope, - name, - mode, - true, - kind, - declaration->initialization()); + var = new(zone()) Variable( + declaration_scope, name, mode, true, kind, + declaration->initialization(), proxy->interface()); var->AllocateTo(Variable::LOOKUP, -1); resolve = true; } diff --git a/test/mjsunit/regress/regress-173361.js b/test/mjsunit/regress/regress-173361.js new file mode 100644 index 0000000..f9cfb66 --- /dev/null +++ b/test/mjsunit/regress/regress-173361.js @@ -0,0 +1,33 @@ +// Copyright 2013 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Flags: --harmony + +const x = 7; + +function f() { const y = 8; } +f();