From: Linus Walleij Date: Mon, 21 Dec 2015 10:21:47 +0000 (+0100) Subject: gpio: msic: Be sure to clamp return value X-Git-Tag: v4.14-rc1~3997^2~163 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=db30aaef313b4d5a2f6151e61e4f3ab5e0affae4;p=platform%2Fkernel%2Flinux-rpi.git gpio: msic: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Acked-by: Mathias Nyman Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c index fe9ef2bc..9a261ac 100644 --- a/drivers/gpio/gpio-msic.c +++ b/drivers/gpio/gpio-msic.c @@ -143,7 +143,7 @@ static int msic_gpio_get(struct gpio_chip *chip, unsigned offset) if (ret < 0) return ret; - return r & MSIC_GPIO_DIN_MASK; + return !!(r & MSIC_GPIO_DIN_MASK); } static void msic_gpio_set(struct gpio_chip *chip, unsigned offset, int value)