From: Seunghun Lee <shiin.lee@samsung.com>
Date: Thu, 22 Aug 2024 09:43:38 +0000 (+0900)
Subject: e_compositor: Remove obsolte implementation
X-Git-Tag: accepted/tizen/unified/20241206.132905~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=db2b7bbe96acad80befd6f41b76843a95290e70f;p=platform%2Fupstream%2Fenlightenment.git

e_compositor: Remove obsolte implementation

This Removes redundant emission of
E_COMP_WL_HOOK_SUBSURFACE_SYNCHRONIZED_COMMIT hook point since it's been
emitted when precommit_from_cache handler is called.

Change-Id: I0a97e2efc93aae63c829c0f1e5c6400abd497b1a
---

diff --git a/src/bin/server/e_compositor.c b/src/bin/server/e_compositor.c
index 89a174c9fc..5c330898e3 100644
--- a/src/bin/server/e_compositor.c
+++ b/src/bin/server/e_compositor.c
@@ -123,7 +123,6 @@ static E_Subsurface *_e_subsurface_try_from_surface(E_Surface *surface);
 static E_Subsurface *_e_subsurface_try_from_resource(struct wl_resource *resource);
 static E_Subsurface *_e_subsurface_try_from_ds_subsurface(struct ds_subsurface *ds_subsurface);
 static void _e_subsurface_destroy(E_Subsurface *sub);
-static void _e_subsurface_commit(E_Subsurface *sub);
 static void _e_subsurface_place_below_parent(E_Subsurface *sub);
 static Eina_Bool _e_subsurface_synchronized_check(E_Subsurface *sub);
 static void _e_subsurface_cb_destroy(struct wl_listener *listener, void *data);
@@ -272,18 +271,17 @@ EINTERN Eina_Bool
 e_comp_wl_subsurface_commit(E_Client *ec)
 {
    E_Surface *surface;
-   E_Subsurface *sub;
 
    EINA_SAFETY_ON_NULL_RETURN_VAL(ec, EINA_FALSE);
 
-   if (e_object_is_del(E_OBJECT(ec)) || !ec->comp_data) return EINA_FALSE;
+   surface = e_surface_try_from_ec(ec);
+   if (!surface)
+     return EINA_FALSE;
 
-   surface = e_surface_from_ec(ec);
-   sub = _e_subsurface_try_from_surface(surface);
-   if (!sub)
+   if (!_e_subsurface_try_from_surface(surface))
      return EINA_FALSE;
 
-   _e_subsurface_commit(sub);
+   e_comp_wl_surface_commit(ec);
 
    return EINA_TRUE;
 }
@@ -1532,18 +1530,6 @@ _e_subsurface_synchronized_check(E_Subsurface *sub)
    return EINA_FALSE;
 }
 
-static void
-_e_subsurface_commit(E_Subsurface *sub)
-{
-   e_comp_wl_surface_commit(sub->surface->ec);
-
-   if (_e_subsurface_synchronized_check(sub))
-     {
-        e_comp_wl_hook_call(E_COMP_WL_HOOK_SUBSURFACE_SYNCHRONIZED_COMMIT,
-                            sub->surface->ec);
-     }
-}
-
 static void
 _e_subsurface_place_below_parent(E_Subsurface *sub)
 {