From: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Date: Sun, 4 Oct 2015 08:56:07 +0000 (+0900)
Subject: Revert "eina: change default log level at which we display backtrace."
X-Git-Tag: v1.16.0-alpha1~18
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=dad345e574efec29c1f686b371fc72491a3f5c47;p=platform%2Fupstream%2Fefl.git

Revert "eina: change default log level at which we display backtrace."

This reverts commit 05c18876b3e2dba5dd7caea2517aaf24d92ab614.

i endabled backtraces by DEFAULT because it is otherwise pretty damned
hard to get them from things like enlightenment, or on tizen apps as
running them on the cmdline and having them work is close to
impossible. yes it's noise. FIX THE ERRORS then. this commit is just
like turning off gcc etc. warnings because the code is too noisy in
compilation with them on. it's a bug. fix it. the bt lets you do that
without gdb or re-executing AGAIN with an env var and HOPING to find
the bug the next time around.

not to mention efl programming docs cover this backtrace and say it
is on by default and how to get useful info out of this. this makes
the elf docs a lie by removing what is documented as default.

@fix
---

diff --git a/src/lib/eina/eina_log.c b/src/lib/eina/eina_log.c
index a9eb9aa..6fc9626 100644
--- a/src/lib/eina/eina_log.c
+++ b/src/lib/eina/eina_log.c
@@ -121,7 +121,7 @@ static Eina_Bool _disable_timing = EINA_TRUE;
 static int _abort_level_on_critical = EINA_LOG_LEVEL_CRITICAL;
 
 #ifdef EINA_LOG_BACKTRACE
-static int _backtrace_level = 1; // CRI & ERR by default
+static int _backtrace_level = 2; // CRI & ERR by default
 #endif
 
 static Eina_Bool _threads_enabled = EINA_FALSE;