From: Bruce Allan <bruce.w.allan@intel.com>
Date: Thu, 20 Sep 2018 00:23:05 +0000 (-0700)
Subject: ice: replace unnecessary memcpy with direct assignment
X-Git-Tag: v5.4-rc1~2266^2~230^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=daca32a2aa05686065d493fc49f316a5a21afb85;p=platform%2Fkernel%2Flinux-rpi.git

ice: replace unnecessary memcpy with direct assignment

Direct assignment is preferred over a memcpy()

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

diff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c b/drivers/net/ethernet/intel/ice/ice_controlq.c
index 3c736b9..6cd86cf 100644
--- a/drivers/net/ethernet/intel/ice/ice_controlq.c
+++ b/drivers/net/ethernet/intel/ice/ice_controlq.c
@@ -850,7 +850,7 @@ ice_sq_send_cmd(struct ice_hw *hw, struct ice_ctl_q_info *cq,
 
 	details = ICE_CTL_Q_DETAILS(cq->sq, cq->sq.next_to_use);
 	if (cd)
-		memcpy(details, cd, sizeof(*details));
+		*details = *cd;
 	else
 		memset(details, 0, sizeof(*details));