From: Kirill A. Shutemov Date: Fri, 8 Jun 2018 00:09:32 +0000 (-0700) Subject: mm/shmem.c: zero out unused vma fields in shmem_pseudo_vma_init() X-Git-Tag: v5.15~8675^2~38 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=daa280753cefa692607190852a98a9c06ae9ec9a;p=platform%2Fkernel%2Flinux-starfive.git mm/shmem.c: zero out unused vma fields in shmem_pseudo_vma_init() shmem/tmpfs uses pseudo vma to allocate page with correct NUMA policy. The pseudo vma doesn't have vm_page_prot set. We are going to encode encryption KeyID in vm_page_prot. Having garbage there causes problems. Zero out all unused fields in the pseudo vma. Link: http://lkml.kernel.org/r/20180531135602.20321-1-kirill.shutemov@linux.intel.com Signed-off-by: Kirill A. Shutemov Reviewed-by: Andrew Morton Cc: Hugh Dickins Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/mm/shmem.c b/mm/shmem.c index 2b686e3..e9a7ac7 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -1420,10 +1420,9 @@ static void shmem_pseudo_vma_init(struct vm_area_struct *vma, struct shmem_inode_info *info, pgoff_t index) { /* Create a pseudo vma that just contains the policy */ - vma->vm_start = 0; + memset(vma, 0, sizeof(*vma)); /* Bias interleave by inode number to distribute better across nodes */ vma->vm_pgoff = index + info->vfs_inode.i_ino; - vma->vm_ops = NULL; vma->vm_policy = mpol_shared_policy_lookup(&info->policy, index); }