From: Jaechul Lee <jcsing.lee@samsung.com>
Date: Fri, 30 Jul 2021 04:45:30 +0000 (+0900)
Subject: device-manager: remove checking module arguments
X-Git-Tag: submit/tizen/20210827.174915~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da998d9560653f48e71f04c2b0adde8061d4f7c5;p=platform%2Fcore%2Fmultimedia%2Fpulseaudio-modules-tizen.git

device-manager: remove checking module arguments

The comparison of the mod args would be failed if unknown args in
device-manager are added like 'echo=1' and it doesn't need to check
module args validation because each module already checks it.

All arguments would be parsed in case of passing NULL.

[Version] 13.0.68
[Issue Type] Improvement

Change-Id: I2be900ef82ecdedc5c181bdc919cd439d0a4b67d
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
---

diff --git a/packaging/pulseaudio-modules-tizen.spec b/packaging/pulseaudio-modules-tizen.spec
index df5e515..3986972 100644
--- a/packaging/pulseaudio-modules-tizen.spec
+++ b/packaging/pulseaudio-modules-tizen.spec
@@ -1,6 +1,6 @@
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          13.0.67
+Version:          13.0.68
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+
diff --git a/src/device-manager.c b/src/device-manager.c
index ef81274..a1a717e 100644
--- a/src/device-manager.c
+++ b/src/device-manager.c
@@ -91,38 +91,6 @@
 #define DEVICE_CLASS_SOUND                  "sound"
 #define DEVICE_CLASS_MONITOR                "monitor"
 
-static const char* const valid_alsa_device_modargs[] = {
-    "name",
-    "sink_name",
-    "sink_properties",
-    "source_name",
-    "source_properties",
-    "namereg_fail",
-    "device",
-    "device_id",
-    "format",
-    "rate",
-    "alternate_rate",
-    "channels",
-    "channel_map",
-    "fragments",
-    "fragment_size",
-    "mmap",
-    "tsched",
-    "tsched_buffer_size",
-    "tsched_buffer_watermark",
-    "ignore_dB",
-    "control",
-    "rewind_safeguard",
-    "deferred_volume",
-    "deferred_volume_safety_margin",
-    "deferred_volume_extra_delay",
-    "fixed_latency_range",
-    "need_audio_pm",
-    "start_threshold",
-    NULL
-};
-
 typedef enum dm_device_class_type {
     DM_DEVICE_CLASS_NONE,
     DM_DEVICE_CLASS_ALSA,
@@ -864,8 +832,8 @@ static bool device_params_is_equal(const char *params1, const char *params2) {
     if (!params1 || !params2)
         return false;
 
-    modargs1 = pa_modargs_new(params1, valid_alsa_device_modargs);
-    modargs2 = pa_modargs_new(params2, valid_alsa_device_modargs);
+    modargs1 = pa_modargs_new(params1, NULL);
+    modargs2 = pa_modargs_new(params2, NULL);
 
     if (!modargs1 || !modargs2) {
         equal = false;