From: Harvey Harrison Date: Wed, 22 Oct 2008 03:28:04 +0000 (-0700) Subject: ALSA: hda - correct bracketing in spdif test in patch_sigmatel.c X-Git-Tag: v3.12-rc1~15779^2~45^2~100 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da74ae3e32374755e0fbdfed4074cf839a82f615;p=kernel%2Fkernel-generic.git ALSA: hda - correct bracketing in spdif test in patch_sigmatel.c Noticed by sparse: sound/pci/hda/patch_sigmatel.c:1285:43: warning: dubious: !x & y Signed-off-by: Harvey Harrison Acked-by: Matthew Ranostay Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index a2ac720..788fdc6 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c @@ -1282,7 +1282,7 @@ static int stac92xx_build_controls(struct hda_codec *codec) return err; spec->multiout.share_spdif = 1; } - if (spec->dig_in_nid && (!spec->gpio_dir & 0x01)) { + if (spec->dig_in_nid && !(spec->gpio_dir & 0x01)) { err = snd_hda_create_spdif_in_ctls(codec, spec->dig_in_nid); if (err < 0) return err;