From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Wed, 21 Jun 2006 14:10:48 +0000 (+0200)
Subject: [PATCH] Remove useless check in drivers/net/pcmcia/xirc2ps_cs.c
X-Git-Tag: v2.6.18-rc1~1081^2~224^2~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da4f5ccf6040b998b64c60db8fa5f4ee03fdaf95;p=platform%2Fkernel%2Flinux-3.10.git

[PATCH] Remove useless check in drivers/net/pcmcia/xirc2ps_cs.c

hi,

coverity choked at this check (id #223), assuming that
skb might be NULL and used anyways later. Since
start_hard_xmit() always gets called with a valid
skb, the check is useless and this patch removes it.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---

diff --git a/drivers/net/pcmcia/xirc2ps_cs.c b/drivers/net/pcmcia/xirc2ps_cs.c
index 71f4505..e80d1e3 100644
--- a/drivers/net/pcmcia/xirc2ps_cs.c
+++ b/drivers/net/pcmcia/xirc2ps_cs.c
@@ -1359,7 +1359,7 @@ do_start_xmit(struct sk_buff *skb, struct net_device *dev)
     kio_addr_t ioaddr = dev->base_addr;
     int okay;
     unsigned freespace;
-    unsigned pktlen = skb? skb->len : 0;
+    unsigned pktlen = skb->len;
 
     DEBUG(1, "do_start_xmit(skb=%p, dev=%p) len=%u\n",
 	  skb, dev, pktlen);