From: Petr Štetiar Date: Mon, 6 May 2019 21:24:46 +0000 (+0200) Subject: staging: octeon-ethernet: Fix of_get_mac_address ERR_PTR check X-Git-Tag: v5.4-rc1~1056^2~4^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da48be3373438224da1a5832cb7ffce1f1752a75;p=platform%2Fkernel%2Flinux-rpi.git staging: octeon-ethernet: Fix of_get_mac_address ERR_PTR check Commit 284eb160681c ("staging: octeon-ethernet: support of_get_mac_address new ERR_PTR error") has introduced checking for ERR_PTR encoded error value from of_get_mac_address with IS_ERR macro, which is not sufficient in this case, as the mac variable is set to NULL initialy and if the kernel is compiled without DT support this NULL would get passed to IS_ERR, which would lead to the wrong decision and would pass that NULL pointer and invalid MAC address further. Fixes: 284eb160681c ("staging: octeon-ethernet: support of_get_mac_address new ERR_PTR error") Signed-off-by: Petr Štetiar Signed-off-by: David S. Miller --- diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c index 2b03018..8847a11 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -421,7 +421,7 @@ int cvm_oct_common_init(struct net_device *dev) if (priv->of_node) mac = of_get_mac_address(priv->of_node); - if (!IS_ERR(mac)) + if (!IS_ERR_OR_NULL(mac)) ether_addr_copy(dev->dev_addr, mac); else eth_hw_addr_random(dev);