From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 5 Jul 2020 20:42:27 +0000 (+0200)
Subject: net: dsa: rtl8366: Pass GENMASK() signed bits
X-Git-Tag: v5.10.7~1943^2~333
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da31735cb9db61dccea0bc9eeb581b41106a247a;p=platform%2Fkernel%2Flinux-rpi.git

net: dsa: rtl8366: Pass GENMASK() signed bits

Oddly, GENMASK() requires signed bit numbers, so that it can compare
them for < 0. If passed an unsigned type, we get warnings about the
test never being true.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
index ac88cac..993cf3a 100644
--- a/drivers/net/dsa/rtl8366.c
+++ b/drivers/net/dsa/rtl8366.c
@@ -272,7 +272,7 @@ int rtl8366_init_vlan(struct realtek_smi *smi)
 			/* For the CPU port, make all ports members of this
 			 * VLAN.
 			 */
-			mask = GENMASK(smi->num_ports - 1, 0);
+			mask = GENMASK((int)smi->num_ports - 1, 0);
 		else
 			/* For all other ports, enable itself plus the
 			 * CPU port.