From: Rafael J. Wysocki Date: Mon, 1 Apr 2013 23:25:09 +0000 (+0200) Subject: USB / PM: Don't try to hide PM QoS flags from usb_port_device_release() X-Git-Tag: v3.12-rc1~1115^2^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da259465d7526804b21d274281fb4d60b4216c82;p=kernel%2Fkernel-generic.git USB / PM: Don't try to hide PM QoS flags from usb_port_device_release() Remove the call to dev_pm_qos_hide_flags(), added by commit 6e30d7cb "usb: Add driver/usb/core/(port.c,hub.h) files", from usb_port_device_release(), because (1) it is completely unnecessary (the flags have been removed already by the PM core during the unregistration of the device object) and (2) it triggers a NULL pointer dereference in sysfs_find_dirent() (dev->kobj.sd is NULL at this point). Signed-off-by: Rafael J. Wysocki Acked-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index 797f9d5..65d4e55 100644 --- a/drivers/usb/core/port.c +++ b/drivers/usb/core/port.c @@ -67,7 +67,6 @@ static void usb_port_device_release(struct device *dev) { struct usb_port *port_dev = to_usb_port(dev); - dev_pm_qos_hide_flags(dev); kfree(port_dev); }