From: Lee Culver Date: Wed, 12 Apr 2023 20:33:06 +0000 (-0700) Subject: Change lldb behavior for new managed command implementations (#3822) X-Git-Tag: accepted/tizen/unified/riscv/20231226.055542~39^2^2~98 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da1cbd2f65477455e09605f0c0f45bb54f446ab0;p=platform%2Fcore%2Fdotnet%2Fdiagnostics.git Change lldb behavior for new managed command implementations (#3822) --- diff --git a/src/SOS/lldbplugin/soscommand.cpp b/src/SOS/lldbplugin/soscommand.cpp index 6bd2fe045..24b5a6e65 100644 --- a/src/SOS/lldbplugin/soscommand.cpp +++ b/src/SOS/lldbplugin/soscommand.cpp @@ -155,7 +155,7 @@ sosCommandInitialize(lldb::SBDebugger debugger) { g_services->AddCommand("sos", new sosCommand(nullptr), "Executes various coreclr debugging commands. Use the syntax 'sos '. For more information, see 'soshelp'."); g_services->AddCommand("ext", new sosCommand(nullptr), "Executes various coreclr debugging commands. Use the syntax 'sos '. For more information, see 'soshelp'."); - g_services->AddCommand("analyzeoom", new sosCommand("AnalyzeOOM"), "Provides a stack trace of managed code only."); + g_services->AddManagedCommand("analyzeoom", "Provides a stack trace of managed code only."); g_services->AddCommand("bpmd", new sosCommand("bpmd"), "Creates a breakpoint at the specified managed method in the specified module."); g_services->AddManagedCommand("clrmodules", "Lists the managed modules in the process."); g_services->AddCommand("clrstack", new sosCommand("ClrStack"), "Provides a stack trace of managed code only."); @@ -170,7 +170,7 @@ sosCommandInitialize(lldb::SBDebugger debugger) g_services->AddCommand("dumpdelegate", new sosCommand("DumpDelegate"), "Displays information about a delegate."); g_services->AddCommand("dumpdomain", new sosCommand("DumpDomain"), "Displays information about the all assemblies within all the AppDomains or the specified one."); g_services->AddCommand("dumpgcdata", new sosCommand("DumpGCData"), "Displays information about the GC data."); - g_services->AddCommand("dumpheap", new sosCommand("DumpHeap"), "Displays info about the garbage-collected heap and collection statistics about objects."); + g_services->AddManagedCommand("dumpheap", "Displays info about the garbage-collected heap and collection statistics about objects."); g_services->AddCommand("dumpil", new sosCommand("DumpIL"), "Displays the Microsoft intermediate language (MSIL) that's associated with a managed method."); g_services->AddCommand("dumplog", new sosCommand("DumpLog"), "Writes the contents of an in-memory stress log to the specified file."); g_services->AddCommand("dumpmd", new sosCommand("DumpMD"), "Displays information about a MethodDesc structure at the specified address."); @@ -184,7 +184,7 @@ sosCommandInitialize(lldb::SBDebugger debugger) g_services->AddCommand("dumpstackobjects", new sosCommand("DumpStackObjects"), "Displays all managed objects found within the bounds of the current stack."); g_services->AddCommand("dso", new sosCommand("DumpStackObjects"), "Displays all managed objects found within the bounds of the current stack."); g_services->AddCommand("dumpvc", new sosCommand("DumpVC"), "Displays info about the fields of a value class."); - g_services->AddCommand("eeheap", new sosCommand("EEHeap"), "Displays info about process memory consumed by internal runtime data structures."); + g_services->AddManagedCommand("eeheap", "Displays info about process memory consumed by internal runtime data structures."); g_services->AddCommand("eestack", new sosCommand("EEStack"), "Runs dumpstack on all threads in the process."); g_services->AddCommand("eeversion", new sosCommand("EEVersion"), "Displays information about the runtime and SOS versions."); g_services->AddCommand("ehinfo", new sosCommand("EHInfo"), "Displays the exception handling blocks in a JIT-ed method."); @@ -192,10 +192,10 @@ sosCommandInitialize(lldb::SBDebugger debugger) g_services->AddCommand("findappdomain", new sosCommand("FindAppDomain"), "Attempts to resolve the AppDomain of a GC object."); g_services->AddCommand("findroots", new sosCommand("FindRoots"), "Finds and displays object roots across GC collections."); g_services->AddCommand("gchandles", new sosCommand("GCHandles"), "Displays statistics about garbage collector handles in the process."); - g_services->AddCommand("gcheapstat", new sosCommand("GCHeapStat"), "Displays statistics about garbage collector."); + g_services->AddManagedCommand("gcheapstat", "Displays statistics about garbage collector."); g_services->AddCommand("gcinfo", new sosCommand("GCInfo"), "Displays info JIT GC encoding for a method."); - g_services->AddCommand("gcroot", new sosCommand("GCRoot"), "Displays info about references (or roots) to an object at the specified address."); - g_services->AddCommand("gcwhere", new sosCommand("GCWhere"), "Displays the location in the GC heap of the specified address."); + g_services->AddManagedCommand("gcroot", "Displays info about references (or roots) to an object at the specified address."); + g_services->AddManagedCommand("gcwhere", "Displays the location in the GC heap of the specified address."); g_services->AddCommand("histclear", new sosCommand("HistClear"), "Releases any resources used by the family of Hist commands."); g_services->AddCommand("histinit", new sosCommand("HistInit"), "Initializes the SOS structures from the stress log saved in the debuggee."); g_services->AddCommand("histobj", new sosCommand("HistObj"), "Examines all stress log relocation records and displays the chain of garbage collection relocations that may have led to the address passed in as an argument."); @@ -207,7 +207,7 @@ sosCommandInitialize(lldb::SBDebugger debugger) g_services->AddManagedCommand("loadsymbols", "Loads the .NET Core native module symbols."); g_services->AddManagedCommand("logging", "Enables/disables internal SOS logging."); g_services->AddCommand("name2ee", new sosCommand("Name2EE"), "Displays the MethodTable structure and EEClass structure for the specified type or method in the specified module."); - g_services->AddCommand("objsize", new sosCommand("ObjSize"), "Displays the size of the specified object."); + g_services->AddManagedCommand("objsize", "Displays the size of the specified object."); g_services->AddCommand("pathto", new sosCommand("PathTo"), "Displays the GC path from to ."); g_services->AddCommand("pe", new sosCommand("PrintException"), "Displays and formats fields of any object derived from the Exception class at the specified address."); g_services->AddCommand("printexception", new sosCommand("PrintException"), "Displays and formats fields of any object derived from the Exception class at the specified address."); @@ -222,7 +222,7 @@ sosCommandInitialize(lldb::SBDebugger debugger) g_services->AddCommand("threadpool", new sosCommand("ThreadPool"), "Displays info about the runtime thread pool."); g_services->AddCommand("threadstate", new sosCommand("ThreadState"), "Pretty prints the meaning of a threads state."); g_services->AddCommand("token2ee", new sosCommand("token2ee"), "Displays the MethodTable structure and MethodDesc structure for the specified token and module."); - g_services->AddCommand("verifyheap", new sosCommand("VerifyHeap"), "Checks the GC heap for signs of corruption."); + g_services->AddManagedCommand("verifyheap", "Checks the GC heap for signs of corruption."); g_services->AddCommand("verifyobj", new sosCommand("VerifyObj"), "Checks the object that is passed as an argument for signs of corruption."); return true; }