From: Dan Carpenter Date: Fri, 18 Nov 2016 11:30:57 +0000 (+0300) Subject: snsc: restore IRQs on error path in scdrv_write() X-Git-Tag: v4.10-rc1~146^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da191c28f571cae4b470b079394bd4a87e459035;p=platform%2Fkernel%2Flinux-exynos.git snsc: restore IRQs on error path in scdrv_write() This bug is as old as git. We need to be calling spin_unlock_irqrestore() instead of regular spin_unlock() here. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/char/snsc.c b/drivers/char/snsc.c index 10e5632..ec07f0e 100644 --- a/drivers/char/snsc.c +++ b/drivers/char/snsc.c @@ -285,7 +285,7 @@ scdrv_write(struct file *file, const char __user *buf, DECLARE_WAITQUEUE(wait, current); if (file->f_flags & O_NONBLOCK) { - spin_unlock(&sd->sd_wlock); + spin_unlock_irqrestore(&sd->sd_wlock, flags); up(&sd->sd_wbs); return -EAGAIN; }