From: Colin LeMahieu Date: Wed, 29 Jul 2015 19:21:13 +0000 (+0000) Subject: [llvm-objdump] Inverting logic to match the word "predicate". Returning true when... X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=da1723f1942cfab05252af2ae45e6b9cd0bb53ef;p=platform%2Fupstream%2Fllvm.git [llvm-objdump] Inverting logic to match the word "predicate". Returning true when we want it rather than when we want to discard it. llvm-svn: 243558 --- diff --git a/llvm/tools/llvm-objdump/llvm-objdump.cpp b/llvm/tools/llvm-objdump/llvm-objdump.cpp index 97243cb..da2e29fc 100644 --- a/llvm/tools/llvm-objdump/llvm-objdump.cpp +++ b/llvm/tools/llvm-objdump/llvm-objdump.cpp @@ -202,7 +202,7 @@ public: private: void ScanPredicate() { - while (Iterator != End && Predicate(*Iterator)) { + while (Iterator != End && !Predicate(*Iterator)) { ++Iterator; } } @@ -231,14 +231,14 @@ private: SectionFilter ToolSectionFilter(llvm::object::ObjectFile const &O) { return SectionFilter([](llvm::object::SectionRef const &S) { if(FilterSections.empty()) - return false; + return true; llvm::StringRef String; std::error_code error = S.getName(String); if (error) - return true; + return false; return std::find(FilterSections.begin(), FilterSections.end(), - String) == FilterSections.end(); + String) != FilterSections.end(); }, O); }